Skip to content

Commit

Permalink
fix: es2017 compatibility (#3371)
Browse files Browse the repository at this point in the history
  • Loading branch information
stepan662 authored Sep 20, 2024
1 parent 1110717 commit c3d0e39
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: always()
with:
name: cypress
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/report-intermittent-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
- name: Cypress
run: pnpm run e2e run --headed ${{matrix.app}} --stdout prod,dev

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ jobs:
- name: Run e2e tests
run: pnpm run e2e run --headed ${{matrix.app}} --stdout prod,dev --skip-build

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress
Expand Down
3 changes: 3 additions & 0 deletions packages/svelte/vite.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { sveltekit } from '@sveltejs/kit/vite';

/** @type {import('vite').UserConfig} */
const config = {
build: {
target: 'es2017',
},
plugins: [sveltekit()],
};

Expand Down
2 changes: 1 addition & 1 deletion packages/web/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "ES2020",
"target": "es2017",
"useDefineForClassFields": true,
"lib": ["ES2020", "DOM", "DOM.Iterable"],
"module": "ESNext",
Expand Down
1 change: 1 addition & 0 deletions packages/web/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const createConfig = ({ entry, rollupOptions }: Props) =>
defineConfig({
clearScreen: false,
build: {
target: 'es2017',
emptyOutDir: false,
minify: false,
sourcemap: true,
Expand Down
2 changes: 1 addition & 1 deletion scripts/e2eRunner/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import path from 'path';
export const config: Config = {
dockerComposeServices: {
app: {
waitForOutput: 'Tomcat started on port(s): 8080 (http)',
waitForOutput: 'Tomcat started on port 8080',
},
},
tests: {
Expand Down

0 comments on commit c3d0e39

Please sign in to comment.