Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable doc_cfg and doc_auto_cfg features on docs.rs #80

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 29, 2021

Replaces #74.

refs: rust-lang/rust#89596, rust-lang/rust#90502
Closes: #74

Screenshots

doc_cfg1

doc_cfg2

doc_cfg3

doc_cfg4

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see that's why I couldn't get this to work without the #[doc(cfg(...))] attributes --- the tweet David referenced didn't mention that an additional feature was necessary to generate it automatically.

This looks good to me!

@taiki-e taiki-e merged commit c21c67e into master Dec 29, 2021
@taiki-e taiki-e deleted the taiki-e/doc branch December 29, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants