Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: implement AsyncBufRead for Join #6449

Merged
merged 1 commit into from
Apr 2, 2024
Merged

io: implement AsyncBufRead for Join #6449

merged 1 commit into from
Apr 2, 2024

Conversation

bharath-123
Copy link
Contributor

@bharath-123 bharath-123 commented Apr 1, 2024 •
edited
Loading

Motivation

The Join struct implements the AsyncRead and AsyncWrite interface. This PR implements the AsyncReadBuf interface.
Fixes #6446

Solution

We implement the AsyncReadBuf interface for the Join, if the Reader also implements the AsyncReadBuf interface.

@mox692 mox692 added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Apr 2, 2024
mox692
mox692 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@Darksonn Darksonn merged commit e9ae5d4 into tokio-rs:master Apr 2, 2024
80 checks passed
@bharath-123 bharath-123 deleted the impl-asyncbufread-for-join branch April 2, 2024 11:08
@Darksonn Darksonn mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mox692 mox692 mox692 approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tokio::io::Join should implement AsyncBufRead
3 participants
@bharath-123 @mox692 @Darksonn