fix: prevent optimize of try_lock in park.rs leading to race conditions (#6355) #6356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses the issue described in #6355, it fixes a segmentation fault in
park_timeout()
on riscv64.Solution
Following the rust documentation on black_box in std::hint it's possible to instruct the compiler to prevent optimizing a specific call.
tokio/tokio/src/runtime/scheduler/multi_thread/park.rs
Line 74 in b32826b
Wrapping
try_lock()
withblack_box()
in park.rs:74 causes the compiler to block optimizations for the call and prevents omission of the call.Tested on Alpine Linux edge (riscv64)
See https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/50419 for details.