sync: make watch::send_replace infallible
#4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to make sense that send_replace can take the current value at any time, considering that even if the receiver is zero when send_replace is called, we can call subscribe later to create a receiver. |
taiki-e
reviewed
Oct 26, 2021
Co-authored-by: Taiki Endo <[email protected]>
taiki-e
approved these changes
Oct 26, 2021
|
Oops a bit slow responding sorry, but well spotted! That solves the problem nicely. Thank you! |
oliver-giersch
pushed a commit
to oliver-giersch/tokio
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the changelog while preparing a release and noticed this opportunity. I'm open to discussing whether this is a good idea.
Closes: #4165
cc @thombles