Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: suppress clippy::default_numeric_fallback lint in generated code #3831

Merged
merged 10 commits into from
Jun 2, 2021
Merged

macros: suppress clippy::default_numeric_fallback lint in generated code #3831

merged 10 commits into from
Jun 2, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jun 1, 2021

Fixes #3830

Workaround for clippy bug: rust-lang/rust-clippy#7304

@taiki-e taiki-e added A-tokio Area: The main tokio crate M-macros Module: macros in the main Tokio crate labels Jun 1, 2021
@taiki-e taiki-e mentioned this pull request Jun 1, 2021
Closed
@taiki-e
Copy link
Member Author

taiki-e commented Jun 1, 2021 •
edited
Loading

oh...

error: unknown clippy lint: clippy::default_numeric_fallback
   --> tokio/tests/macros_select.rs:543:8
    |
543 | #[warn(clippy::default_numeric_fallback)]
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D clippy::unknown-clippy-lints` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unknown_clippy_lints

clippy::default_numeric_fallback was added in rust 1.52.0 (rust-lang/rust-clippy@e2753f9)

@taiki-e taiki-e merged commit 9d8b37d into tokio-rs:master Jun 2, 2021
@taiki-e taiki-e deleted the macros-clippy-default_numeric_fallback branch June 2, 2021 09:16
@Darksonn Darksonn mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-macros Module: macros in the main Tokio crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tokio::select not compatible with clippy::default_numeric_fallback
2 participants
@taiki-e @Darksonn