Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding playground-specific metadata #1932

Closed
shepmaster opened this issue Dec 9, 2019 · 6 comments · Fixed by #1960
Closed

Consider adding playground-specific metadata #1932

shepmaster opened this issue Dec 9, 2019 · 6 comments · Fixed by #1960

Comments

@shepmaster
Copy link
Contributor

Version

0.2.x

Description

With the changes in 0.2.x to use a feature-flagged tokio crate where everything is off by default, there's the possibility of Tokio not being shown in its best light on the playground.

The playground has custom metadata that allows crate owners to opt in to what features will be enabled on the playground.

This is not an immediate concern as Tokio is currently only brought into the playground as a dependency (of hyper and reqwest), so whatever flags they use should be sufficient, once they update to 0.2.x.

@carllerche
Copy link
Member

I would be happy to add whatever metadata. Are you able to submit a PR w/ that?

@carllerche
Copy link
Member

How does one get Tokio 0.2 in the playground?

@shepmaster
Copy link
Contributor Author

How does one get Tokio 0.2 in the playground?

The criteria is one of:

  • Be in the Rust Cookbook
  • Be one of the top 100 downloaded crates
  • Be a dependency of a crate otherwise included

Generally, the only directly-actionable route is the cookbook.

Are you able to submit a PR w/ that?

I could. I assume that full would be the correct general-purpose feature?

@carllerche
Copy link
Member

Yep, full is the way to go.

@carllerche
Copy link
Member

I guess once hyper is updated to 0.2, then tokio will be included. I guess we should fix it before that...

@LucioFranco
Copy link
Member

Yeah, we should def include it as full 👍 thanks for reaching out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants