Ship with FranklinUtils #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 99.23% 99.06% -0.18%
==========================================
Files 5 4 -1
Lines 131 107 -24
==========================================
- Hits 130 106 -24
Misses 1 1
Continue to review full report at Codecov.
|
|
this needs a release of FranklinUtils before it can be merged right? otherwise, great, thanks! |
|
I'll merge this when JuliaRegistries/General#20351 is in |
|
Happy to merge this when tests are passing, thanks! |
|
@tlienart done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utils weren't public API anyway, so I think this is safe for merging.