Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(application): allow url values to options #1887

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix(application): allow url values to options #1887

merged 1 commit into from
Apr 28, 2022
+37 −4

Conversation

leoryu
Copy link
Contributor

@leoryu leoryu commented Apr 28, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@leoryu leoryu requested a review from choujimmy as a code owner April 28, 2022 03:30
@leoryu leoryu merged commit aec4502 into tkestack:master Apr 28, 2022
@leoryu leoryu deleted the fix/application_url_values branch April 28, 2022 03:38
huxiaoliang pushed a commit that referenced this pull request May 7, 2022
@huxiaoliang
fix(application): allow url values to options (#1887)
d95a870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choujimmy choujimmy Awaiting requested review from choujimmy choujimmy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leoryu