Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes getattr from settings to account for None values #57

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

kbuilds
Copy link
Collaborator

@kbuilds kbuilds commented Oct 11, 2021

This change makes it easier to configure the port and host settings from environment variables.

For example, I might set this up in my settings.py as:

LIVERELOAD_HOST = os.getenv("LIVERELOAD_HOST")
LIVERELOAD_PORT = os.getenv("LIVERELOAD_PORT")

This makes it so that developers on my team can specify these values in their environment variables. The default return value for getenv() when the variable is not found is None. This PR makes sure that a value of None in the settings.py file does not break this livereload system.

@kbuilds
Copy link
Collaborator Author

kbuilds commented Dec 10, 2021

@tjwalch Is this project still active?

@tjwalch
Copy link
Owner

tjwalch commented Dec 13, 2021

@kbuilds It has been sort of inactive for I while, I have been too busy with other stuff. I am however planning to give it a look, merge PR's and make a new release within the next week or so.

@tjwalch tjwalch merged commit ad100b1 into tjwalch:master Dec 14, 2021
@kbuilds
Copy link
Collaborator Author

kbuilds commented Dec 14, 2021

@tjwalch Let me know if you need some help. I have experience with Django and Tornado

@tjwalch
Copy link
Owner

tjwalch commented Dec 22, 2021

@kbuilds Yes, I think this project could benefit from some more collaborators, if you are interested in that I can add you to the project.

@kbuilds
Copy link
Collaborator Author

kbuilds commented Dec 22, 2021

@tjwalch Sure. I would be happy to help. I already have a fork, but feel free to add me as a maintainer or contributor. Whatever is easier. Maybe we can chat about what kinds of features you are trying to add here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants