Partials ignore express' views folder #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following situation:
Appfolder/app.js:
→ Consolidate looks for
Appfolder/views/account/_head.html
instead ofAppfolder/views/_head.html
which is the default views folder we defined earlier.This is in my eyes pretty unfavorable because we don't have a chance to define "default" partials using app.locals() since the folder consolidate is looking for templates differs for every view and depends on the folder the currently compiled template is placed in.
In my version consolidate checks if a default
views
folder was defined and if so, loads the partials from there instead of from the current path.app.locals({partials: {head: '_head'}});
then always looks forAppfolder/views/_head.html
and ignores the current working dir which makes life much easier.