Combine normalize and parseoptions, and update combined option handling #1152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
(This is the same PR as #1145, but rebased to clean up the commits listed.)
Problem
.parse()
called a private routine.normalize()
to split short options, turn--long=value
into--long value
, et al. This caused a few subtle problems:.parseOptions()
-fValue
(added in #395 fix, short options do not understand adjacent values #599) only worked for top level commanddo sub --flag=--version
Solution
.parseOptions
and delete.normalise
So for example:
Can now call like:
ChangeLog
Added
-a -b -p 80
can be written as-abp80
) (parseOptions rework phase 2 #1145).parseOption()
includes short flag and long flag expansions (parseOptions rework phase 2 #1145)Changed
-ab
or--foo=bar
) (parseOptions rework phase 2 #1145)Fixed
-p80
) (parseOptions rework phase 2 #1145)Removed
normalize
(the functionality has been integrated intoparseOptions
)