Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move @types/node to devDependencies #719

Closed
timocov opened this issue Nov 23, 2017 · 2 comments
Closed

Move @types/node to devDependencies #719

timocov opened this issue Nov 23, 2017 · 2 comments

Comments

@timocov
Copy link

timocov commented Nov 23, 2017 •
edited
Loading

Please move @types/node to devDependencies section instead of dependencies https://github.com/tj/commander.js/blob/master/package.json#L26.

I guess that nobody want to have this types in their web-based project (for example tslint have commander as deps) (@types/node may be installed as cross-deps)
@timocov timocov changed the title Mode @types/node to devDependencies Move @types/node to devDependencies Nov 23, 2017
@timocov
Copy link
Author

timocov commented Nov 23, 2017

Related to #646

@timocov timocov mentioned this issue Nov 23, 2017
Closed
vchimev pushed a commit to NativeScript/nativescript-marketplace-demo that referenced this issue Nov 23, 2017
fix(ts): cast setTimeout() to avoid TS errors
204a119 
ERROR in [at-loader] ./app/examples/conference-agenda/conference-agenda-example.ts:63:5
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/conference-agenda/conference-agenda-example.ts:71:9
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/user-profile/user-profile-example.ts:89:5
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/user-profile/user-profile-example.ts:97:9
    TS2322: Type 'Timer' is not assignable to type 'number'.

Caused by tj/commander.js#719.
vchimev pushed a commit to NativeScript/nativescript-marketplace-demo that referenced this issue Nov 23, 2017
fix(ts): cast setTimeout() to avoid TS errors
9936924 
ERROR in [at-loader] ./app/examples/conference-agenda/conference-agenda-example.ts:63:5
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/conference-agenda/conference-agenda-example.ts:71:9
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/user-profile/user-profile-example.ts:89:5
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/user-profile/user-profile-example.ts:97:9
    TS2322: Type 'Timer' is not assignable to type 'number'.

Caused by tj/commander.js#646.
Related to tj/commander.js#719.
@vchimev vchimev mentioned this issue Nov 23, 2017
Merged
vchimev pushed a commit to NativeScript/nativescript-marketplace-demo that referenced this issue Nov 23, 2017
fix(ts): cast setTimeout() to avoid TS errors (#282)
f3f0f35 
ERROR in [at-loader] ./app/examples/conference-agenda/conference-agenda-example.ts:63:5
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/conference-agenda/conference-agenda-example.ts:71:9
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/user-profile/user-profile-example.ts:89:5
    TS2322: Type 'Timer' is not assignable to type 'number'.

ERROR in [at-loader] ./app/examples/user-profile/user-profile-example.ts:97:9
    TS2322: Type 'Timer' is not assignable to type 'number'.

Caused by tj/commander.js#646.
Related to tj/commander.js#719.
@timocov timocov mentioned this issue Nov 23, 2017
Closed
@abetomo
Copy link
Collaborator

abetomo commented Nov 23, 2017

It is fixed by #718

@abetomo abetomo closed this as completed Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abetomo @timocov