Refactor _checkForBrokenPassThrough() to make it instance-aware

tj · Aug 5, 2023 · ac8db3a · ac8db3a
1 parent ec1942d
commit ac8db3a
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/lib/command.js b/lib/command.js
@@ -272,7 +272,7 @@ class Command extends EventEmitter {
 
     this.commands.push(cmd);
     cmd.parent = this;
-    this._checkForBrokenPassThrough(cmd, this);
+    cmd._checkForBrokenPassThrough();
 
     return this;
   }
@@ -737,19 +737,17 @@ Expecting one of '${allowedValues.join("', '")}'`);
    */
   passThroughOptions(passThrough = true) {
     this._passThroughOptions = !!passThrough;
-    this._checkForBrokenPassThrough(this, this.parent);
+    this._checkForBrokenPassThrough();
     return this;
   }
 
   /**
-   * @param {Command} command
-   * @param {Command | null} parent
    * @api private
    */
 
-  _checkForBrokenPassThrough(command, parent) {
-    if (parent && command._passThroughOptions && !parent._enablePositionalOptions) {
-      throw new Error(`passThroughOptions cannot be used for '${command._name}' without turning on enablePositionalOptions for parent command(s)`);
+  _checkForBrokenPassThrough() {
+    if (this.parent && this._passThroughOptions && !this.parent._enablePositionalOptions) {
+      throw new Error(`passThroughOptions cannot be used for '${this._name}' without turning on enablePositionalOptions for parent command(s)`);
     }
   }