Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Needs to be Ivy compliant [Angular 16] #134

Closed
kwhjvdkamp opened this issue Jul 4, 2023 · 20 comments
Closed

[Bug] Needs to be Ivy compliant [Angular 16] #134

kwhjvdkamp opened this issue Jul 4, 2023 · 20 comments
Labels
released

Comments

@kwhjvdkamp
Copy link

kwhjvdkamp commented Jul 4, 2023 •
edited
Loading

Ngx-CookieConsent Version

3.1.1

CookieConsent Version

3.1.1

Angular CLI (or Nx CLI) Version

[ng version] Angular 16.1.3

Node Version

18.16.0

OS Version

Windows 11

Expected Behaviour

Working library! It seems, I misted the fact this library seems to be a non-Ivy version. Such libraries became deprecated using Angular 16.

Is there any chance, this package is going to be upgraded, becoming Ivy compliant? Please (company Osano) let the comunity know if it stays around as a non-Ivy one. People should know, thanks.

Actual Behaviour

As notified during upgrade process
Generating browser application bundles (phase: setup)...
Processing legacy 'View Engine' library:

ngx-cookieconsent [es2015/esm2015] (git://github.com/tinesoft/ngx-cookieconsent.git)

Notification from Angular upgrade team:
Encourage the library authors to publish an Ivy distribution

Steps to reproduce the behaviour

n/a
@kwhjvdkamp kwhjvdkamp changed the title [Bug] [Bug] Needs to be Ivy compliant [Angular 16] Jul 7, 2023
@bardyguillaume
Copy link

Hi have you got any update on angular 16 as
we have incompatibility
Error: node_modules/ngx-cookieconsent/cookieconsent.module.d.ts:7:53 - error NG6005: NgcCookieConsentModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If this occurrence is in library code you don't control, please contact the library authors.

7 static forRoot(config: NgcCookieConsentConfig): ModuleWithProviders;
~~~~~~~~~~~~~~~~~~~

@kwhjvdkamp
Copy link
Author

kwhjvdkamp commented Aug 21, 2023 via email

@bardyguillaume
Copy link

Sorry Thanks for advice
I understand
Not easy 😅

@tinesoft
Copy link
Owner

Hi guys,

Thanks for using the library and sorry for the delay in responding....
I will have a look ASAP. Stay tuned

@nishchithas
Copy link

Any update on this for Angular 16? Has any one found work around for this issue?

@tinesoft
Copy link
Owner

tinesoft commented Jan 4, 2024

Hi guys!

Sorry for the delay in fixing this. I have been busy with work + other oss projects...

But bear with me a bit longer, I will start updating the library to support modern angular, later this week

Stay tuned!

@kwhjvdkamp
Copy link
Author

No! Unfortunately not!
Trouble, trouble, trouble. Skipped this cookie-stuff... ...doesn't run on Angular 16, also many other things broken! Tried to rebuild the whole thing. Base site finally runs on Angular 17, however another problem, now stucked on getting firestore running in Angular 17. Still many complications between packages.

Actually, lost motivation to get it repaired.

@nishchithas
Copy link

nishchithas commented Jan 4, 2024 •
edited
Loading

@kwhjvdkamp

No! Unfortunately not! Trouble, trouble, trouble. Skipped this cookie-stuff... ...doesn't run on Angular 16, also many other things broken! Tried to rebuild the whole thing. Base site finally runs on Angular 17, however another problem, now stucked on getting firestore running in Angular 17. Still many complications between packages.

Actually, lost motivation to get it repaired.

What is the alternative you are using in Angular 17?

@nishchithas
Copy link

@tinesoft Any updates?

@kwhjvdkamp
Copy link
Author

kwhjvdkamp commented Jan 8, 2024 •
edited
Loading

...finally able to get my site up-and-running again, able to fetch data from from the firestore cloud ! With that having said, it's running without cookie-stuff, service-worker, internationalization (including left-and-right orientation). I had to remove these functionality also some other stuff based on HighCharts.

I really don't no what has changed ! I was - after many trial-and-errors - able to build and deploy it to firebase, however only in the development mode. I seems to be able to build a production version however it can't be deployed due to mime errors on the script package, in the production flow need to tweek manually the index.html from the dist-folder; it's looking into the wrong sub folder, so I need to tweak manually the path to the scripts packages and surpringly if I got that fixed, it won't build a styles-package. It became really 'whipped cream' between my ears!

So, overnight, I took the short corner, gambled on the fact being able to deploy the latest develop-version! So, luckily the basic side is running (not the version it should be, but)... ...oh wel!

Did not have any second left to dive into reimplement cookie-stuff

https://consult-koen.web.app/#/home

@tinesoft
Copy link
Owner

tinesoft commented Jan 10, 2024 •
edited
Loading

Hi guys,

Hang tight! I've just released v5.0.0 ( fully compatible with Angular 15 + added support for standalone API).

I will check for compatibility with Angular 16 and beyond, (hopefully tonight) and perform subsequent releases if needed.

Until then, you can try out this new version and report here if you have issue....

@kwhjvdkamp
Copy link
Author

Hi, thanks !

However, may bring up this...
image !

@tinesoft
Copy link
Owner

tinesoft commented Jan 10, 2024 •
edited
Loading

@kwhjvdkamp Looks like a configuration issue on your side (probably the provided cookie.domain URL) . The demo app (built with Angular v15 for now) does not give this warning... Can you share your config?

Btw, Is your original Ivy compilation issue solved ?

@kwhjvdkamp
Copy link
Author

Hi Tine, No not solved! I decided to get rid of every IVY-related deprecated code. With that said; service-worker, internationalization and cookie stuff. Also several HighCharts aren't working anymore. I needed my base up-and-running, for now its acceptable. Need to continue with other things...

@tinesoft
Copy link
Owner

Ok, thanks for the info.

I will certainly release a v6.0.0 (compatible with Angular >=16) later today...

tinesoft added a commit that referenced this issue Jan 10, 2024
@tinesoft
feat: update to Angular v16+
6031528 
BREAKING CHANGE: Angular ` v16+`  is now the minimal version to use the library.

Closes #134
github-actions bot pushed a commit that referenced this issue Jan 10, 2024
@semantic-release-bot
chore(release): 🚀 release v6.0.0
0a0c9b0 
# [6.0.0](v5.0.0...v6.0.0) (2024-01-10)

### Features

* update to Angular `v16+` ([6031528](6031528)), closes [#134](#134)

### BREAKING CHANGES

* Angular ` v16+`  is now the minimal version to use the library.

***
[skip ci]
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tinesoft
Copy link
Owner

https://github.com/tinesoft/ngx-cookieconsent/releases/tag/v6.0.0 was released with support for Angular 16+

@kwhjvdkamp can you give it a try and let me know if everything OK ?

@kwhjvdkamp
Copy link
Author

@tinesoft
TineKondo

@Guigeek973
Copy link

Hello, i'm now using angular 18 and it seems to don't work anymore, can't understand why... Is any people has the same issue ? What was the change between 16 to 18 that broke (again) the package ?

@kwhjvdkamp
Copy link
Author

kwhjvdkamp commented Oct 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tinesoft @kwhjvdkamp @bardyguillaume @Guigeek973 @nishchithas