-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Angular 14 #123
Comments
same issue here, it's not showing up in angular 14 |
same here |
Hi guys, Thanks for the interest in the library. |
any news? |
Hi, we require support for angular 14 as well, this now prevents us from upgrading our application. Or we have to use a different cookie consent solution, which would be a shame since it worked perfectly so far :-) |
@tinesoft Hi, we would also like to use this feature and are really happy with the cookiebar. We don't want to use another cookiebar component. When will this be upgraded to Angular 14? |
Do you have an ETA perhaps? We need to fix our cookie bar this week, otherwise we need to install another library. |
I have fixed that by switching to cookieconsent library app.module.ts
|
Hi again everyone, Sorry for the delay... I'm sure y'all understand, finding the right balance between my fulltime job (not OSS unfortunately :-( ), maintaining my OSS projects, and other life stuff, is not always easy... That being said, I feel the strong need for Angular 14 support. So I will start working on it this weekend. Please bear with me, and thanks for you understanding and support 🙏🏾 |
BREAKING CHANGE: Angular 14 is now the minimal required version Closes #123
Hi folks, Thanks for your patience. As promised, I've just released v4.0.0 of the library with Angular 14 support! EDIT: There are no actual breaking changes in this version , in terms of API or anything, just the Angular version bump. PS: a minor |
BREAKING CHANGE: Angular 14 is now the minimum required version to use the module. Closes #123
# [4.0.0](v3.0.1...v4.0.0) (2022-10-10) ### Bug Fixes * **version:** update docs about version compatible with Ng 12 to 13 ([c323e26](c323e26)) ### Features * **core:** migrate to Angular 14 and Nx 14 ([#125](#125)) ([7d8024d](7d8024d)), closes [#123](#123) ### BREAKING CHANGES * **core:** Angular 14 is now the minimum required version to use the module. *** [skip ci]
🎉 This issue has been resolved in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@tinesoft Same here unfortunately :-/ When can we expect an update on this? |
@tinesoft We would like to launch our website, but this blocking issue is stopping us from doing so. Do you have an ETA on when this issue will be fixed? |
Hi guys, sorry I somehow wasn't notified of the message after having closed the issue.... @Noppey, @erwindemoel can you elaborate on what bug you are having ? |
@erwindemoel I will need more info than just that screenshot ^^ I tested the library with my demo application (running ng14) and it is working fine.
|
@angular-devkit/architect 0.1402.5
The problem seems to occur when we translate the text in app.component.ts. When I comment out the call to updateCookieLanguage, it works normally.
Does that help you to reproduce the issue? |
Hi It looks like a problem in your code i'm afraid.... nothing to do with the library itself, nor with Angular 14 support. Maybe you call that updateCookieLanguage() too soon? before the libray has initialised properly ? In the documentation and demo app, i used @ngx-translate ( which is similar to ng-transloco), and it works fine... |
We have resolved the issue |
@erwindemoel Glad to hear that! For completeness, and in case it might help others, can you elaborate on how you solved the issue and what it was? Thanks |
We used this.translocoService.selectTranslate to translate different messages at once. This worked differently with ngx-translate and our newly implemented translocoService. That broke the cookiebar. |
Is your feature request related to a problem? Please describe
nothing
Describe the idea you'd like
Is an angular 14 migration already planned ? Or is it ready to use it with angular 14 ?
Describe alternatives you've considered
nothing
Additional context
nothing
The text was updated successfully, but these errors were encountered: