Add FieldMask utilities and message merge options #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcready
commented
Aug 9, 2023
| @@ -105,12 +106,12 @@ describe('reflectionMergePartial()', () => { | |||
| describe('and source field empty', () => { | |||
| const source: object = {child: undefined}; | |||
| it('does not touch target', () => { | |||
| const target: any = {child: 123}; | |||
| const target: any = {child: 123, children: []}; | |||
There was a problem hiding this comment.
These tests are janky. The target/source for these tests do not follow the rules of what should be passed to reflectionMergePartial() (e.g. the MessageInfo.fields describe T). Any T should never have optional repeated fields (like children). The new implementation of reflectionMergePartial() depends on it.
| @@ -119,12 +120,12 @@ describe('reflectionMergePartial()', () => { | |||
| describe('and source field null', () => { | |||
| const source: object = {child: null}; | |||
| it('does not touch target', () => { | |||
| const target: any = {child: 123}; | |||
| const target: any = {child: 123, children: []}; | |||
There was a problem hiding this comment.
Janky. child is a "message" field, not a "scalar" number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #58
The majority of the tests were pulled from the official python and java implementations.
As a consequence of implementing the "canonical" behavior for merging messages using a
FieldMask(namely: by default repeated fields are appended (not replaced) and there is the ability to "clear" singular message fields in the target if they are unset in the source) this change also adds the conceptMergeOptionswhich is now optionally able to be passed to the pre-existingMessageType.mergePartial()andreflectionMergePartial().