Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FieldMask JSON read/write (snake_case <-> camelCase) conforming #552

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Make FieldMask JSON read/write (snake_case <-> camelCase) conforming #552

merged 1 commit into from
Jul 31, 2023

Conversation

jcready
Copy link
Contributor

@jcready jcready commented Jun 29, 2023

Fixes #396

timostamm
timostamm approved these changes Jul 31, 2023
View reviewed changes
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@timostamm timostamm merged commit 52c9df5 into timostamm:main Jul 31, 2023
@jcready jcready deleted the fix-field-mask-snake-camel-case branch August 1, 2023 12:26
This was referenced May 24, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request May 24, 2024
Open
This was referenced Aug 10, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 10, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FieldMask JSON read/write (snake_case <-> camelCase) is non-conforming
2 participants
@jcready @timostamm