Fix jstype = JS_STRING field option for speed optimized code #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in internal-binary-read.ts When the field option jstype = JS_STRING was set, the generated method `internalBinaryRead` would still read the field as a bigint. This problem only surfaces if the plugin parameter long_type_string is *not* set and code is optimized for speed (instead of for code size).
|
Also fixed in master. Released in v1.0.10 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in internal-binary-read.ts
When the field option jstype = JS_STRING was set, the generated method
internalBinaryReadwould still read the field as a bigint.This problem only surfaces if the plugin parameter long_type_string is not set and code is optimized for speed (instead of for code size).