-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added force_disable_services
option to protobuf-ts/plugin for disabling service metadata generation
#268
Added force_disable_services
option to protobuf-ts/plugin for disabling service metadata generation
#268
Conversation
… a corresponding option parser.
…sable service metadata generation.
Hey @timostamm I was wondering if the option name |
This is likely caused by lerna, the tool to link the packages within this monorepo. Please try to run |
…w disables generation of services, clients, and server interfaces.
This is also a feature that we need, since we only are using protobuf-ts to generate the TS types and encoding/decoding functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColinLaws, thanks for the update! I think we need to explain the option with a bit more detail, but that should be it.
if (params?.force_disable_services) { | ||
o.forceDisableServices = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should set forcedServerStyle
and forcedClientStyle
here to be explicit, but can't think of a case the very obvious if-statement below wouldn't catch.
Released in v2.7.0. |
disable_service_types
option to protobuf-ts/plugin for disabling service metadata generationforce_disable_services
option to protobuf-ts/plugin for disabling service metadata generation
Summary of changes
Small change to introduce optionality in generating service metadata for proto messages. I have named the option
disable_service_types
.Precaution
I am having difficulty understanding how to run tests after following the guide provided in
CONTRIBUTING.md
. I was not able to run tests successfully againstpackages/plugin
, as I have an error that@protobuf-ts/plugin-framework
is missing. I made sure to build and test the plugin-framework, but still I encounter issues when trying to run tests for the plugin package. Any help in contributing is appreciated, I'd like to make sure I'm not introducing bugs into this library. Thanks everyone.