Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass grpc-js MetadataOptions to GrpcOptions in grpc-tr… #261

Merged
merged 2 commits into from
May 16, 2022
Merged

Add ability to pass grpc-js MetadataOptions to GrpcOptions in grpc-tr… #261

merged 2 commits into from
May 16, 2022

Conversation

kskalski
Copy link
Contributor

@kskalski kskalski commented Apr 1, 2022

…ansport.

@kskalski kskalski mentioned this pull request Apr 1, 2022
Open
@timostamm
Copy link
Owner

Apologies for the delay, I'm preoccupied with personal matters at the moment, but will get back to this ASAP.

timostamm
timostamm reviewed Apr 23, 2022
View reviewed changes
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing that change through on @grpc/grpc-js!

Could you update the import? Otherwise, this looks good to merge.

packages/grpc-transport/src/util.ts Outdated Show resolved Hide resolved
timostamm
timostamm approved these changes May 16, 2022
View reviewed changes
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timostamm timostamm merged commit c219f16 into timostamm:master May 16, 2022
@timostamm
Copy link
Owner

Released in v2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kskalski @timostamm