Update parseTrailer function to support empty trailers & trailers with colon in content #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2021 02:43
…h colon in content
jcready
reviewed
Oct 2, 2021
Co-authored-by: James Wyatt Cready-Pyle <[email protected]>
|
Released in v2.0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When message ends with
128, 0, 0, 0, 0and trailerData is empty, splitting it by\r\nresulting array contains one empty string.This causes error:
Also, if trailer has colon in content it stripping because of limit. See #166
This PR fixes this bugs, according to grpc-web protocol.