Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate clients for @grpc/grpc-js #57

Closed
8 tasks done
timostamm opened this issue Dec 21, 2020 · 1 comment
Closed
8 tasks done

Generate clients for @grpc/grpc-js #57

timostamm opened this issue Dec 21, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone
2.0

Comments

@timostamm
Copy link
Owner

timostamm commented Dec 21, 2020 •
edited
Loading

As an alternative to generic service clients and the gRPC transport, it might be beneficial to generate a @grpc/grpc-js client.

This would allow users to use all features provided by @grpc/grpc-js.
It should ease migration from protobuf-js protobuf-ts.

TODO

  • manually setup a client to see what needs to be generated - todo-generate.ts
  • should server stream also accept callback? -> no package grpc-tools doesn't either
  • create code generator
    • honor reserved names
    • use plugin parameter "client_grpc1"
  • create example project
  • split GrpcOptions and manage client life cycle, see Memory leak in @protobuf-ts/grpc-transport #107
  • documentation (MANUAL.md)
@timostamm timostamm added the enhancement New feature or request label Dec 21, 2020
@timostamm timostamm mentioned this issue Dec 23, 2020
Open
@timostamm timostamm mentioned this issue Jan 27, 2021
Closed
timostamm added a commit that referenced this issue Jan 30, 2021
@timostamm
#57
f41e78e 
manually setup a client to see what needs to be generated
timostamm added a commit that referenced this issue Jan 30, 2021
@timostamm
#57
357c8ba
timostamm added a commit that referenced this issue Jan 30, 2021
@timostamm
#57
63c82d0 
- created code generator
- use plugin parameter "client_grpc1"
- created example project
timostamm added a commit that referenced this issue Jan 30, 2021
@timostamm
#57
fb86982 
- honor reserved names
timostamm added a commit that referenced this issue Jan 30, 2021
@timostamm
#57 update example README.md
c3e5274
timostamm added a commit that referenced this issue Jan 30, 2021
@timostamm
#57 update example README.md
113e0b6
timostamm added a commit that referenced this issue Jan 30, 2021
@timostamm
#57 update example README.md
2d5d4cc
@timostamm timostamm mentioned this issue Apr 10, 2021
Closed
@timostamm timostamm added this to the 2.0 milestone Apr 10, 2021
@timostamm
Copy link
Owner Author

Added a short section in the manual and added a link in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@timostamm