Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support message options #35

Closed
timostamm opened this issue Nov 26, 2020 · 1 comment
Closed

Support message options #35

timostamm opened this issue Nov 26, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@timostamm
Copy link
Owner

Custom field options are added to the generated code as JSON. Same for service options and method options.

But message options are missing.

It should be straight-forward to add this feature. MessageType should have an "options" property just like ServiceType.
@timostamm timostamm added the enhancement New feature or request label Nov 26, 2020
@timostamm timostamm mentioned this issue Nov 26, 2020
Closed
@timostamm timostamm changed the title Add message options to generated code Support message options Nov 26, 2020
@timostamm timostamm mentioned this issue Dec 23, 2020
Open
timostamm added a commit that referenced this issue May 13, 2021
@timostamm
#35 adding "options" property to the message type
c536317 
Similar to what we already have for services, methods and fields.

The options are not generated by the plugin yet.
timostamm added a commit that referenced this issue May 13, 2021
@timostamm
#35 output message options in generated code
05db978 
This uncovered some problems with proto2 compatibility.
Notably skipping of groups in the binary format and handling group fields in a robust way. Groups are now ignored completely by the plugin, but should be treated as unknown fields by the runtime.
timostamm added a commit that referenced this issue May 13, 2021
@timostamm
Update info about proto2 support for #35
a56901b
@timostamm
Copy link
Owner Author

Released in v2.0.0-alpha.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timostamm