#94 generate type imports in grpc-client

timostamm · Apr 6, 2021 · 8d77a32 · 8d77a32
1 parent 541877f
commit 8d77a32
Show file tree

Hide file tree

Showing 7 changed files with 70 additions and 60 deletions.
diff --git a/packages/example-node-grpc-client/service-example.grpc-client.ts b/packages/example-node-grpc-client/service-example.grpc-client.ts
@@ -1,11 +1,11 @@
-// @generated by protobuf-ts 2.0.0-alpha.12 with parameters client_grpc1,generate_dependencies,optimize_code_size
+// @generated by protobuf-ts 2.0.0-alpha.18 with parameters client_grpc1,generate_dependencies,optimize_code_size
 // @generated from protobuf file "service-example.proto" (package "spec", syntax proto3)
 // tslint:disable
 import { ExampleService } from "./service-example";
-import { BinaryWriteOptions } from "@protobuf-ts/runtime";
-import { BinaryReadOptions } from "@protobuf-ts/runtime";
-import { ExampleResponse } from "./service-example";
-import { ExampleRequest } from "./service-example";
+import type { BinaryWriteOptions } from "@protobuf-ts/runtime";
+import type { BinaryReadOptions } from "@protobuf-ts/runtime";
+import type { ExampleResponse } from "./service-example";
+import type { ExampleRequest } from "./service-example";
 import * as grpc from "@grpc/grpc-js";
 /**
  * @generated from protobuf service spec.ExampleService

diff --git a/packages/example-node-grpc-client/service-example.ts b/packages/example-node-grpc-client/service-example.ts
@@ -1,4 +1,4 @@
-// @generated by protobuf-ts 2.0.0-alpha.12 with parameters client_grpc1,generate_dependencies,optimize_code_size
+// @generated by protobuf-ts 2.0.0-alpha.18 with parameters client_grpc1,generate_dependencies,optimize_code_size
 // @generated from protobuf file "service-example.proto" (package "spec", syntax proto3)
 // tslint:disable
 import { ServiceType } from "@protobuf-ts/runtime-rpc";

diff --git a/packages/example-node-grpc-client/tsconfig.json b/packages/example-node-grpc-client/tsconfig.json
@@ -11,6 +11,11 @@
     "moduleResolution": "node",
     "forceConsistentCasingInFileNames": true,
     "skipLibCheck": false,
+
+    // activated for issue #94
+    // svelte requires this option
+    "importsNotUsedAsValues": "error",
+
     "lib": [
       "es2017",
       "dom"

diff --git a/packages/example-node-grpc-server/service-example.grpc-server.ts b/packages/example-node-grpc-server/service-example.grpc-server.ts
@@ -1,4 +1,4 @@
-// @generated by protobuf-ts 2.0.0-alpha.8 with parameters server_grpc1,client_none,generate_dependencies,optimize_code_size
+// @generated by protobuf-ts 2.0.0-alpha.18 with parameters server_grpc1,client_none,generate_dependencies,optimize_code_size
 // @generated from protobuf file "service-example.proto" (package "spec", syntax proto3)
 // tslint:disable
 import { ExampleResponse } from "./service-example";

diff --git a/packages/example-node-grpc-server/service-example.ts b/packages/example-node-grpc-server/service-example.ts
@@ -1,4 +1,4 @@
-// @generated by protobuf-ts 2.0.0-alpha.8 with parameters server_grpc1,client_none,generate_dependencies,optimize_code_size
+// @generated by protobuf-ts 2.0.0-alpha.18 with parameters server_grpc1,client_none,generate_dependencies,optimize_code_size
 // @generated from protobuf file "service-example.proto" (package "spec", syntax proto3)
 // tslint:disable
 import { ServiceType } from "@protobuf-ts/runtime-rpc";

diff --git a/packages/example-node-grpc-server/tsconfig.json b/packages/example-node-grpc-server/tsconfig.json
@@ -11,6 +11,11 @@
     "moduleResolution": "node",
     "forceConsistentCasingInFileNames": true,
     "skipLibCheck": false,
+
+    // activated for issue #94
+    // svelte requires this option
+    "importsNotUsedAsValues": "error",
+
     "lib": [
       "es2017",
       "dom"

diff --git a/packages/plugin/src/code-gen/service-client-generator-grpc.ts b/packages/plugin/src/code-gen/service-client-generator-grpc.ts