Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for direction tag into viewpoint pois #1916

Merged
merged 6 commits into from
Aug 9, 2019
Merged

Add support for direction tag into viewpoint pois #1916

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd3a80b
Add support for direction tag into viewpoint pois
rwrx Jul 8, 2019
70dd074
Move direction property for pois into pois global properties
Jul 29, 2019
0b00eb1
Add conversion from cardinal to degrees for pois direction property
Jul 29, 2019
900f59d
Revise conversion from cardinal to degrees for pois direction property
Jul 29, 2019
9636852
Fix Circle failing checks
Jul 29, 2019
e18b5dd
Fix Circle whitespaces
Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions yaml/pois.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2206,6 +2206,7 @@ filters:
output:
<<: *output_properties
kind: viewpoint
direction: {col: direction}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many more POIs that include direction, so let's move this to the very top of the YAML doc after wikidata_id: {col: wikidata} in the

global:
  - &output_properties:

section, please.

- filter:
tourism: information
name: true
Expand Down