Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wetland POIs with kind_detail. #1785

Merged
merged 3 commits into from
Jan 11, 2019
Merged

Conversation

zerebubuth
Copy link
Member

Wetland landuse areas already existed, but for many of the examples in #1253 were being overridden by the boundary=national_park. I've swapped that around, so that natural=wetland matches first (as long as it doesn't have a protect_class or protect_title that would make us think it's a national park), and added it as a POI type to match.

Connects to #1253.

…tional park, so that we don't mistakenly classify a national park as a wetland instead.
@zerebubuth zerebubuth requested a review from nvkelso January 11, 2019 17:40
@@ -1251,6 +1252,9 @@ Common values include `pit_latrine`, ` flush`, ` chemical`, ` pour_flush`, ` buc

Common values include: `drinkable_powered`, `drinkable_manual`, `drinkable_no_pump`, `drinkable`, `not_drinkable_powered`, `not_drinkable_manual`, `not_drinkable_no_pump`, `not_drinkable`.

#### Wetland `kind_detail` values
The value of the OpenStreetMap `wetland` tag. If available, value will be one of: `bog`, `fen`, `mangrove`, `marsh`, `mud`, `reedbed`, `saltern`, `saltmarsh`, `string_bog`, `swamp`, `tidalflat`, `wet_meadow`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: markdown now requires an extra line whitespace between headers and body text.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 83eecab.

Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one markdown nit.

@nvkelso nvkelso merged commit 9f83812 into master Jan 11, 2019
@nvkelso nvkelso deleted the zerebubuth/1253-wetland-kind-detail branch January 11, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants