Add building material tag to output. #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkelso
reviewed
Dec 14, 2017
docs/layers.md
Outdated
| @@ -210,6 +210,7 @@ Values for `kind_detail` are sourced from OpenStreetMap's `building` tag for bu | |||
| * `addr_housenumber`: value from OpenStreetMap's `addr:housenumber` tag | |||
| * `addr_street`: value from OpenStreetMap's `addr:street` tag | |||
| * `area`: in square meters (spherical Mercator, no real-world), `polygon` features only. _See planned bug fix in [#1095](https://github.com/tilezen/vector-datasource/issues/1095)._ | |||
| * `building_material`: A description of the material covering the outside of the building or building part, if the information is available. Common values are: `cement_block`, `brick`, `plaster`, `wood`, `concrete`, `metal`, `stone`, `traditional`, `glass`, `mud`, `masonry`, `steel`, `semi-permanent`, `tin`, `permanent`, `timber-framing`, `sandstone`, `clay` and `other`, and there are many other less common values. | |||
There was a problem hiding this comment.
Generally we alphabetize these sorts of lists.
There was a problem hiding this comment.
This was in order of the number of uses, descending. I thought that would be more useful to anyone who only wants to support the top N values. Would it be better to call that out, or alphabetise the list and let people pick values they think are important?
nvkelso
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #1408.