Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wikidata id concordance to features #858

Closed
nvkelso opened this issue Jun 13, 2016 · 13 comments
Closed

Add wikidata id concordance to features #858

nvkelso opened this issue Jun 13, 2016 · 13 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Jun 13, 2016

Customer request to add wikidata ids wikipedia links to features (in the POIs layer).

@nvkelso
Copy link
Member Author

nvkelso commented Jun 13, 2016

Some questions:

  • Examples of Wikipedia OSM tags on POIs and other features
  • What is the use case for the tags?
  • Why limit this only to the POIs layer?

@zerebubuth
Copy link
Member

Examples:

One interesting example that I expected to find, but did not appear to have a wikipedia tag, was the famous bit of Lombard. Opportunity for improvement.

I assume the use-case for the tags are to show extra information about the history or context of a particular object. To have a "more info" link which opens up a wikipedia page in another tab, for example. Or just to make it easier to collate the data for bundling into an offline tourist map, perhaps?

I think we should add this to all layers, although on layers other than POIs we probably want to remove the tag at mid zooms to avoid getting in the way of merging.

@erikschlegel
Copy link

I agree and mispoke about adding it to only the POI layer as places /
landmarks can span across the places / landuse / POI and other mapzen
vector layers. Our current use-case is that we're extracting points of
interest and places by using Mapzens vector tile service. In the event
where an openstreetmap POI has a wikipedia link, we provide users with the
ability to request for more information which is basically the first
paragraph from the intro in Wikipedia. I'm currently using Overpass as a
short-term workaround, until the vector service has the wikipedia tags
available. Great point on coalescing the variant wiki link tags into a
single field(i.e. wikipedia / wikipedia:es) similar to what you're doing
with the 'kind' field. This would be such an incredibly useful data set to
include in the vector tile service. My only concern about including a "more
info" link is that if the media wiki API service hosts changes then all the
links break, and also dealing with the multiple output types. Including the
wikipedia page title reference(s) into the Mapzen vector service would be a
great start.

All the best,

Erik

On Tue, Jun 14, 2016 at 6:31 AM, Matt Amos [email protected] wrote:

Examples:

One interesting example that I expected to find, but did not appear to
have a wikipedia tag, was the famous bit of Lombard
http://www.openstreetmap.org/way/402111597. Opportunity for improvement.

I assume the use-case for the tags are to show extra information about the
history or context of a particular object. To have a "more info" link which
opens up a wikipedia page in another tab, for example. Or just to make it
easier to collate the data for bundling into an offline tourist map,
perhaps?

I think we should add this to all layers, although on layers other than
POIs we probably want to remove the tag at mid zooms to avoid getting in
the way of merging.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#858 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHSDmTd21jThCDF23NUYD_Y1AUxenq0eks5qLoMagaJpZM4I0kEH
.

@zerebubuth
Copy link
Member

Hi Erik,

Sorry if I wasn't clear - I meant to suggest passing through the wikipedia (and wikipedia:*) tags as they currently are in OSM, which is mostly page title references. As you say, it's better to use the page title not the link so that the client can construct the appropriate "more info" URL itself, or look up the content from a local device cache, or something else.

@erikschlegel
Copy link

Hey Matt,

Does the vector tile service provide the street intersection nodes by any
chance? If not, would the returned polyline shapes provide the intersecting
point(s) for 2 roads which happen to intersect?

All the best,

Erik

On Tue, Jun 14, 2016 at 9:27 AM, Matt Amos [email protected] wrote:

Hi Erik,

Sorry if I wasn't clear - I meant to suggest passing through the wikipedia
(and wikipedia:*) tags as they currently are in OSM, which is mostly page
title references. As you say, it's better to use the page title not the
link so that the client can construct the appropriate "more info" URL
itself, or look up the content from a local device cache, or something else.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#858 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHSDmfU9EnY6yLCDvGRbIcu0-SQjT4gkks5qLqw8gaJpZM4I0kEH
.

@zerebubuth
Copy link
Member

Hi Erik,

Our tiles don't contain a separate point geometry for street intersections, although the point would normally be part of the linestring geometries of both the roads. I caveat "normally" because we currently simplify road geometries at zoom levels between 8 and 15 (inclusive), which may result in intersection points being elided if the road is mostly straight.

Would having separate point geometries with the main and cross street names be useful?

@nvkelso nvkelso added the ready label Jul 8, 2016
@nvkelso nvkelso removed the ready label Jul 18, 2016
@nvkelso nvkelso added this to the v1.6.0 milestone Jul 6, 2018
@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Sep 25, 2018
@nvkelso nvkelso modified the milestones: v1.9.0, v1.8.0 Feb 20, 2019
@nvkelso nvkelso changed the title Add wikipedia links to features Add wikidata id concordance to features Apr 10, 2019
@ghost ghost assigned zerebubuth Apr 17, 2019
@ghost ghost added the in review label Apr 17, 2019
@nvkelso
Copy link
Member Author

nvkelso commented May 9, 2019

Verified:

image

image

@nvkelso nvkelso closed this as completed May 9, 2019
@ghost ghost removed the in review label May 9, 2019
@nvkelso
Copy link
Member Author

nvkelso commented May 9, 2019

Actually, looks like the WOF portion of this isn't totally working?

Western Addition should link to Q7987437 via WOF's 85856855 concordance.

image

@nvkelso nvkelso reopened this May 9, 2019
@zerebubuth
Copy link
Member

Thanks for checking that!

There's at least one bug: tilezen/raw_tiles#32

However, that should only affect high-zoom tiles, and we do include WOF neighbourhoods at z11, which I think should be generated directly from the database (because our metatile size means a nominal z11 tile is a z10 512px tile, which is generated from a z8 metatile/job). But an example (Miramar, San Diego) also shows no wikidata_id. So I'll need to do more debugging 😕

@nvkelso
Copy link
Member Author

nvkelso commented May 29, 2019

Still missing wikidata_id from high zooms as reported in #858 (comment).

@zerebubuth
Copy link
Member

🤦‍♂️ 🤬 💥 ⁉️

Looks like I forgot to click "merge" on tilezen/raw_tiles#32... D'oh!

I guess this means we won't be using the v18e build as 1.8 final 😞, sorry.

@nvkelso
Copy link
Member Author

nvkelso commented May 30, 2019

Doh! Easy explanation, though :)

@nvkelso
Copy link
Member Author

nvkelso commented Jun 7, 2019

Verified in new build, closing.

image

@nvkelso nvkelso closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants