Add island labels

[nvkelso]

earth layer label positions:

• place=island Identifies the coastline of an island (> 1 km2), also consider place=islet for very small islands. zoom 14 default, area adjusted up to zoom 9
• place=islet Identifies an islet (< 1 km2). zoom 16 default, area adjusted up to zoom 15.
• place=archipelago {Relation} Identifies the relation of an archipelago, which contains several islands and islets. zoom 14 default, area adjusted up to zoom 9

These islands of southern California have names, but we don't include them yet:

z10/33.9060/-119.9944

Looks like the related tag is:

http://wiki.openstreetmap.org/wiki/Tag:place=island

But sometimes it's hiding on relation parts, fun.

[nvkelso]

Looks like these would also be useful:

• place=archipelago {Relation} Identifies the relation of an archipelago, which contains several islands and islets.
• place=island {Area} Identifies the coastline of an island (> 1 km2), also consider place=islet for very small islands
• place=islet {Node, Area} Identifies an islet (< 1 km2).

[nvkelso]

Target layer: physical-labels or earth or places, tbd.

[nvkelso]

Load balancing to v0.8

[rmarianski]

Is that what's happening in this case? Seems like it's coming through in the tile in the boundaries layer. This looks to be the relevant osm feature.

Can certainly add the places you mentioned, just don't think it'll help with this example, unless I'm missing something.

[rmarianski]

Err sorry, I see it in the landuse layer. An example tile is: 10/171/409.

[nvkelso]

Other candidates, from http://taginfo.openstreetmap.org/tags/natural=strait:

• natural=peninsula
• natural=headland
• natural=cape
• natural=isthmus

[nvkelso]

That feature is the national park, this is the (generic) island, tagged place=island:

• http://www.openstreetmap.org/relation/237600#map=12/34.0184/-119.7252

Distraction: The one you mention seems to have gotten corrupted somewhere (either in OSM or in our processing), the name of the "county" is not Santa Cruz Island!

[nvkelso]

@rmarianski I'd like to reprioritize adding island labels until later in the milestone. If this safe to move into the backlog or do you have partial code for it now?

[rmarianski]

De-prioritizing sounds good. The actual code change was minimal.

[nvkelso]

We're getting multiple island labels per feature part for each child tile:

10/33.9741/-119.8279

13/37.8595/-122.4186

14/37.8147/-122.3811

[zerebubuth]

Ooops, yeah. Looks like we need to pre-calculate centroids and split off the label_placement: yes points from the polygons.

[nvkelso]

@rmarianski can you finish this off, please? I'm fading with jet lag.

If I remove label_position: yes from the output for islands, islets, and archipelago, then that fixes the multiple points per feature problem, but then all the node tests fail. As Matt suggests, we need to select the points separate from the polygons.

Additionally, these 2 polygon tests fail, likely because the resulting point is in a neighboring tile and the test just needs to be updated.

# LARGE island labels (from place polygons)
# http://www.openstreetmap.org/relation/4227580
# Manitoulin Island, Canada
# assert_has_feature(
#     7, 34, 45, 'earth',
#     { 'kind': 'island', 'label_placement': 'yes', 'name': 'Manitoulin Island' })

# LARGE island labels (from place polygons)
# http://www.openstreetmap.org/relation/5176042
# Trinidad, the island of the nation
# assert_has_feature(
#     7, 42, 60, 'earth',
#     { 'kind': 'island', 'label_placement': 'yes', 'name': 'Trinidad' })

[nvkelso]

Working for me :)