Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust min_zoom of OSM highways and major roads to better match Natural Earth #1279

Closed
nvkelso opened this issue Jun 23, 2017 · 4 comments
Closed

Comments

@nvkelso
Copy link
Member

nvkelso commented Jun 23, 2017

@sensescape is adding optional level of detail filters to Refill and is making use of the min_zoom to do the filtering. But for the roads layer there's a discontinuity between the Natural Earth data at zooms 0-7 and the OSM data that starts at 8. Many roads that already showed up in earlier zooms only have a min_zoom of 8 set, when they should have an earlier zoom.

  #############################################################
  #
  # OSM highway
  #
  #############################################################
  - filter:
      highway: motorway
    # min_zoom 8 ≤ any mz_calculate_path_major_route(), so skip
    min_zoom: 8
    table: osm
    output:
      <<: *osm_highway_properties
      <<: *osm_network
      kind: highway
      kind_detail: motorway
  - filter:
      highway: [trunk, primary]
    # min_zoom 8 ≤ any mz_calculate_path_major_route(), so skip
    min_zoom: 8
    table: osm
    output:
      <<: *osm_highway_properties
      <<: *osm_network
      kind: major_road
      kind_detail: {col: highway}
@nvkelso
Copy link
Member Author

nvkelso commented Jun 23, 2017

One solution:

  • highway: motorway at min_zoom: 5
  • highway: trunk at min_zoom: 6
  • highway: primary at min_zoom: 8

@nvkelso nvkelso added this to the v1.4.0 milestone Jun 23, 2017
@nvkelso
Copy link
Member Author

nvkelso commented Jun 23, 2017

Related: #1280

@nvkelso nvkelso changed the title Adjust min_zoom of OSM highways and major roads Adjust min_zoom of OSM highways and major roads to better match Natural Earth Jun 23, 2017
@nvkelso
Copy link
Member Author

nvkelso commented Jul 27, 2017

Subtask of #1349.

@nvkelso nvkelso self-assigned this Nov 28, 2017
@nvkelso nvkelso removed their assignment Jun 5, 2018
@nvkelso nvkelso modified the milestones: v1.5.0, v1.6.0 Jun 14, 2018
@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Nov 5, 2018
@nvkelso nvkelso modified the milestones: v1.8.0, v1.7.0 Jan 8, 2019
@nvkelso nvkelso modified the milestones: v1.9.0, v1.8.0 Feb 20, 2019
@ghost ghost assigned nvkelso May 1, 2019
@ghost ghost added the in review label May 1, 2019
@nvkelso
Copy link
Member Author

nvkelso commented May 9, 2019

Verified:

image

image

image

@nvkelso nvkelso closed this as completed May 9, 2019
@ghost ghost removed the in review label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant