Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for v1.2.0 #63

Merged
merged 2 commits into from
Feb 6, 2017
Merged

Update changelog for v1.2.0 #63

merged 2 commits into from
Feb 6, 2017

Conversation

iandees
Copy link
Member

@iandees iandees commented Feb 6, 2017

No description provided.

@iandees iandees requested a review from nvkelso February 6, 2017 18:44
CHANGELOG.md Outdated
v1.2.0
------
* Roll back the use of psycopg2 connection pools. (See [tilequeue/#149](https://github.com/tilezen/tilequeue/pull/149) and [#62](https://github.com/tilezen/tileserver/pull/62))
* Try increasing the maximum connection count on connection pools. (See [#61](https://github.com/tilezen/tileserver/pull/61))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try increasing to Increase

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though did this change stay in after #62?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's why I used "Try"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not releasing this change by tagging 1.2.0, let's not mention it in the changelog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'm used to putting all changes between two tags in the changelog, regardless of if the resulting code is in there. Happy to not include it though.

@iandees
Copy link
Member Author

iandees commented Feb 6, 2017

How's this updated version look, @nvkelso?

@nvkelso
Copy link
Member

nvkelso commented Feb 6, 2017

LGTM

@iandees iandees merged commit e6c49b6 into master Feb 6, 2017
@iandees iandees deleted the update_changelog_v1.2.0 branch February 6, 2017 20:38
@iandees iandees removed the in review label Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants