Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data fetcher constructor #59

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Conversation

rmarianski
Copy link
Member

@zerebubuth, @iandees could you review please?

@iandees I'm assuming that it's ok for the minimum and maximum values to be the same for tileserver.

@iandees
Copy link
Member

iandees commented Jan 23, 2017

Hmm, it might not be a good idea to set the max connections to be the same as min. Let me look a little closer 🔍 .

@iandees
Copy link
Member

iandees commented Jan 23, 2017

I might be off-by-one here, but I think if we set min and max to the same thing, we won't be able to request all N connections because of this pair of lines: https://github.com/psycopg/psycopg2/blob/master/lib/pool.py#L90-L91

@rmarianski
Copy link
Member Author

It still looks like we'd be ok to me because that branch will only get triggered if there's nothing in self._pool, which will have the minimum number of connections in it.

I deployed this branch to dev so we can wait to see if we get any errors in tileserver related to this after some usage.

@iandees
Copy link
Member

iandees commented Jan 23, 2017

Yep, you're right. I think we're OK here.

@rmarianski rmarianski merged commit c7ddd45 into master Jan 24, 2017
@rmarianski rmarianski deleted the update-datafetcher-init branch January 24, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants