Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change to on demand instance type #86

Merged
merged 2 commits into from
Jun 3, 2021
Merged

change to on demand instance type #86

merged 2 commits into from
Jun 3, 2021

Conversation

tgrigsby-sc
Copy link
Contributor

No description provided.

@tgrigsby-sc tgrigsby-sc requested review from iandees and peitili June 2, 2021 23:21
@nvkelso
Copy link
Member

nvkelso commented Jun 2, 2021

Let's add in the README (?) that this is default configured for EC2, but SPOT is also possible and reference this PR for demo code?

iandees
iandees approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@iandees iandees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks good. Agree that we should include a mention of undoing this PR to use spot pricing in the readme or something.

@tgrigsby-sc
Copy link
Contributor Author

Good call. I was going to add this in a followup so I good refer to a specific commit, but the PR works just fine for this too.

@tgrigsby-sc tgrigsby-sc merged commit 4b050b2 into master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peitili peitili peitili approved these changes

@iandees iandees iandees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tgrigsby-sc @nvkelso @iandees @peitili