Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: fix rule manager initialize #8937

Merged
merged 4 commits into from
Dec 20, 2024
Merged

mcs: fix rule manager initialize #8937

merged 4 commits into from
Dec 20, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Dec 19, 2024

What problem does this PR solve?

Issue Number: Close #8935

What is changed and how does it work?

Check List

Tests

  • Unit test
    Before:
    img_v3_02hn_2c79077c-fe96-4de2-ac36-dd2ba698c6cg
    After:
    image

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Dec 19, 2024
Signed-off-by: lhy1024 <[email protected]>
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.31%. Comparing base (7889b67) to head (3424185).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8937      +/-   ##
==========================================
+ Coverage   76.30%   76.31%   +0.01%     
==========================================
  Files         462      462              
  Lines       70440    70447       +7     
==========================================
+ Hits        53746    53765      +19     
+ Misses      13350    13334      -16     
- Partials     3344     3348       +4     
Flag Coverage Δ
unittests 76.31% <91.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 19, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-19 09:28:08.227692479 +0000 UTC m=+1121878.316495023: ☑️ agreed by rleungx.
  • 2024-12-20 03:20:49.981438978 +0000 UTC m=+1186240.070241520: ☑️ agreed by bufferflies.

@ti-chi-bot ti-chi-bot bot merged commit 0e5d49f into tikv:master Dec 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

placement rules changed after scheduling leader changed
3 participants