Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebCrypto is not available by default on node v18 #1655

Merged
merged 2 commits into from
Sep 12, 2024
Merged

WebCrypto is not available by default on node v18 #1655

merged 2 commits into from
Sep 12, 2024

Conversation

gniezen
Copy link
Member

@gniezen gniezen commented Sep 12, 2024

@krystophv I was showing the Uploader CLI tools to @ewollesen yesterday, and we discovered that I broke them with the Uploader-in-Web merge. Here is a small fix - since it's not user-facing, I'm not going to create a Jira ticket and will just merge it in if you approve?

@gniezen gniezen requested a review from krystophv September 12, 2024 13:56
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@gniezen gniezen merged commit fa47347 into master Sep 12, 2024
2 of 4 checks passed
@gniezen gniezen deleted the fix-cli branch September 12, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants