Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve messaging when there are no (new) records (UPLOAD-1295) #1650

Merged
merged 13 commits into from
Oct 3, 2024
Merged

Improve messaging when there are no (new) records (UPLOAD-1295) #1650

merged 13 commits into from
Oct 3, 2024

Conversation

gniezen
Copy link
Member

@gniezen gniezen commented Aug 6, 2024 •
edited by jira bot
Loading

Addresses UPLOAD-1295.

@gniezen
Copy link
Member Author

gniezen commented Aug 6, 2024

This work should not be merged before #1639, as it has been merged into this PR>

@gniezen gniezen requested a review from krystophv August 13, 2024 15:31
krystophv
krystophv previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Couple small questions about consistency with the debug() calls.

lib/drivers/bayer/bayerContourNext.js Show resolved Hide resolved
lib/drivers/abbott/abbottFreeStyleLibre.js Show resolved Hide resolved
@gniezen gniezen requested a review from krystophv September 26, 2024 10:15
krystophv
krystophv previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

vojtech-cerveny
vojtech-cerveny approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@vojtech-cerveny vojtech-cerveny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ QA approved. No errors during testing, LGTM 🚀

@gniezen gniezen removed the request for review from krystophv October 1, 2024 14:27
@gniezen gniezen merged commit 7537217 into master Oct 3, 2024
4 checks passed
@gniezen gniezen deleted the handle-empty branch October 3, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtech-cerveny vojtech-cerveny vojtech-cerveny approved these changes

@krystophv krystophv krystophv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gniezen @krystophv @vojtech-cerveny