[UPLOAD-1224] replace react-keycloak with react-oidc-context
#1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintonium-119
approved these changes
May 6, 2024
app/auth.js
Outdated
| import * as ActionTypes from './constants/actionTypes'; | ||
| import { sync, async } from './actions'; | ||
| import api from '../lib/core/api'; | ||
| import rollbar from './utils/rollbar'; |
There was a problem hiding this comment.
I noticed that rollbar is no longer used. If this is intentionally left out from the conversion from keycloak.js, then the import should likely be removed
There was a problem hiding this comment.
Ah yeah, the new library doesn't really have code paths for the sort of error that we were experiencing and logging for the Keycloak version. I'll drop the import.
corrects manual logout redirecting to "logged out" page instead of "login" and prevents auto-login on "login" page if #state is still valid
|
@krystophv We can merge this into the UiW branch, right? |
|
@gniezen Yeah, will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UPLOAD-1224, pretty much what it says on the tin.
react-keycloakis a dead/archived project at this point, so replacing it is the prudent thing to do. Was hoping that the diff would pick upkeycloak.js->auth.jsas a rename, but I guess it was different enough that it treats it as a separate file. Some pieces of it got much simpler, some more complex. It still relies onkeycloak.jsfor some specifics like generating the registration URL and logout URL (which is more relevant onblip, but for the sake of parity is also included here).