Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for time update messaging (UPLOAD-1201, UPLOAD-1157) #1621

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

gniezen
Copy link
Member

@gniezen gniezen commented Apr 8, 2024

Addresses UPLOAD-1201 and UPLOAD-1157.

@gniezen gniezen requested a review from krystophv April 8, 2024 13:46
krystophv
krystophv previously approved these changes Apr 8, 2024
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@gniezen gniezen changed the title Fix regression on meter/CGM time update messaging (UPLOAD-1201) Fix regression on meter/CGM time update messaging (UPLOAD-1201, UPLOAD-1157) Apr 9, 2024
@gniezen
Copy link
Member Author

gniezen commented Apr 9, 2024

@krystophv I decided to add UPLOAD-1157 to this PR, as they're both related to the update-time modal.

@gniezen gniezen changed the title Fix regression on meter/CGM time update messaging (UPLOAD-1201, UPLOAD-1157) Fixes for time update messaging (UPLOAD-1201, UPLOAD-1157) Apr 9, 2024
krystophv
krystophv previously approved these changes Apr 9, 2024
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@vojtech-cerveny
Copy link
Contributor

@gniezen, build-macos check fails and it is required to merge. Can you check it what's wrong please?

It seems that github already have this asset, if I get it right.

From log:

Failed Task: build
Stack Trace: HttpError: 422 Unprocessable Entity

Method: POST
URL: https://uploads.github.com/repos/tidepool-org/uploader/releases/150421733/assets?name=Tidepool%20Uploader-2.57.0-time-message-fix.2-mac.zip.blockmap

Data:
{
  "message": "Validation Failed",
  "request_id": "C1A7:368889:27CDF3:2C0534:66686CB9",
  "documentation_url": "https://docs.github.com/rest",
  "errors": [
    {
      "resource": "ReleaseAsset",
      "code": "already_exists",
      "field": "name"
    }
  ]
}

@gniezen
Copy link
Member Author

gniezen commented Jun 20, 2024

@vojtech-cerveny There's a bug in electron-builder that hasn't been fixed for years. Unfortunately there's nothing that we can do about it, so the workarounds are:

  • bump the version number to create a new build that doesn't have existing assets
  • delete the assets and trigger the build again

I just did the second one. Keep in mind that this PR cannot be merged even though UPLOAD-1201 has been approved, as UPLOAD-1157 is also linked to this PR and still needs to be tested.

@krystophv krystophv merged commit 9385879 into master Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants