-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for time update messaging (UPLOAD-1201, UPLOAD-1157) #1621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
@krystophv I decided to add UPLOAD-1157 to this PR, as they're both related to the update-time modal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
@gniezen, It seems that github already have this asset, if I get it right. From log:
|
@vojtech-cerveny There's a bug in electron-builder that hasn't been fixed for years. Unfortunately there's nothing that we can do about it, so the workarounds are:
I just did the second one. Keep in mind that this PR cannot be merged even though UPLOAD-1201 has been approved, as UPLOAD-1157 is also linked to this PR and still needs to be tested. |
Addresses UPLOAD-1201 and UPLOAD-1157.