Add support for OneTouch Ultra Plus Flex meter (UPLOAD-1175) #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystophv
previously approved these changes
Mar 25, 2024
There was a problem hiding this comment.
LGTM 🚀
Just noting that it required a couple tweaks to the notary system to (1) disable electron-builder's built in notary function since we're using the afterSign script and (2) removing a property that causes electron-notarize to fall back to the legacy notary system which now errors out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses UPLOAD-1175.
I also cherry-picked @krystophv 's fixes for CircleCI to get the Windows binary to build.