-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPLOAD-1187][UPLOAD-1186][UPLOAD-1179] enforce patient limit #1611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
I agree that it makes sense to just drop the code straight in from blip where possible, even if some of it is unused.
Less effort now, and less effort down the road. win-win.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes LGTM 🚢
for UPLOAD-1187, UPLOAD-1186 - add UI that shows patient limit modal when attempting to add a patient that would put the clinic over their limit. This "borrows" a lot of the
blip
code for these things verbatim, which technically includes some dead code paths, but I think the benefit from keeping the relevant files in sync outweighs the drawback of having some unused code. (I'm not dead set on this and could probably be convinced otherwise if there's a good argument for it)adds the two line fix for UPLOAD-1179 as it came up as an issue for me when doing verification