Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPLOAD-1187][UPLOAD-1186][UPLOAD-1179] enforce patient limit #1611

Merged
merged 18 commits into from
Mar 28, 2024

Conversation

krystophv
Copy link
Member

@krystophv krystophv commented Mar 14, 2024

for UPLOAD-1187, UPLOAD-1186 - add UI that shows patient limit modal when attempting to add a patient that would put the clinic over their limit. This "borrows" a lot of the blip code for these things verbatim, which technically includes some dead code paths, but I think the benefit from keeping the relevant files in sync outweighs the drawback of having some unused code. (I'm not dead set on this and could probably be convinced otherwise if there's a good argument for it)

adds the two line fix for UPLOAD-1179 as it came up as an issue for me when doing verification

clintonium-119
clintonium-119 previously approved these changes Mar 15, 2024
Copy link
Member

@clintonium-119 clintonium-119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
I agree that it makes sense to just drop the code straight in from blip where possible, even if some of it is unused.

Less effort now, and less effort down the road. win-win.

Copy link
Member

@clintonium-119 clintonium-119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes LGTM 🚢

@krystophv krystophv merged commit 06a6c4f into master Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants