Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPLOAD-1139] CircleCI resource class update #1588

Merged
merged 20 commits into from
Oct 9, 2023
Merged

[UPLOAD-1139] CircleCI resource class update #1588

merged 20 commits into from
Oct 9, 2023

Conversation

krystophv
Copy link
Member

@krystophv krystophv commented Sep 28, 2023 •
edited by jira bot
Loading

to address UPLOAD-1139, we need to update the CircleCI runner class since the Intel based medium is being sunset at the end of Sept 2023

@krystophv
[UPLOAD-1139] update circleCI config resource_class
98306f7
@krystophv
v2.54.2-circleci-resource.1
2b6b79f
@krystophv
[UPLOAD-1139] update CI image
6a5d571
@krystophv
v2.54.2-circleci-resource.2
454c4db
@krystophv
[UPLOAD-1139] try a less major update for environment
ae118b1
@krystophv
[UPLOAD-1139] try suggested older workaround
7f22be9
@krystophv
[UPLOAD-1139] pull cert into parent directory
df5a410
@krystophv
[UPLOAD-1139] change directories
dca629b
@krystophv
[UPLOAD-1139] cert after checkout
ed4975c
@krystophv
[UPLOAD-1139] try to add cert to default keychain
dea84ca
@krystophv
[UPLOAD-1139] trying a previously CircleCI suggested cert fix
9221331
@krystophv
[UPLOAD-1139] removing certs that already exist in the image
29ef305
@krystophv
[UPLOAD-1139] stepping back manual cert mgmt, update electron-builder
47d7cca
@krystophv
update lockfile
9c1f9ef
@krystophv
[UPLOAD-1139] try to set up default keychain manually
9e006b6
@krystophv
[UPLOAD-1139] CSC_LINK is base64 encoded cert
ce11529
@krystophv
v2.54.2-circleci-resource.3
31b9687
@krystophv
cleanup commented out earlier attempts
2cdf6be
@krystophv
v2.54.2-circleci-resource.4
c051b69
@krystophv krystophv requested a review from gniezen September 29, 2023 02:31
gniezen
gniezen approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@gniezen gniezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on finding a workaround for this! 👏 LGTM!

We should keep an eye on electron-builder to see if they manage to start using Apple's new certs and if that resolves the issue, in which case we can remove this again 🤞

@krystophv krystophv merged commit 9685ba6 into master Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gniezen gniezen gniezen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystophv @gniezen