Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show actionable error message when Accu-chek meter doesn't respond (UPLOAD-958) #1581

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

gniezen
Copy link
Member

@gniezen gniezen commented Sep 4, 2023

Addresses UPLOAD-958.

@gniezen gniezen requested a review from krystophv September 4, 2023 13:20
@tjotala tjotala changed the title Show actionable error message when Accu-chek meter doesn't respond (UPLOAD-958) Show actionable error message when Accu-chek meter doesn't respond (UPLOAD-958) Sep 4, 2023
@tjotala tjotala changed the title Show actionable error message when Accu-chek meter doesn't respond (UPLOAD-958) Show actionable error message when Accu-chek meter doesn't respond (UPLOAD-958) Sep 4, 2023
krystophv
krystophv previously approved these changes Sep 5, 2023
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gniezen
Copy link
Member Author

gniezen commented Nov 6, 2023

@krystophv Just noticed I made some changes since last review, please have a look before I merge

@gniezen gniezen requested a review from krystophv November 6, 2023 16:22
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@gniezen gniezen merged commit a2ab50f into master Nov 6, 2023
1 check failed
@gniezen gniezen deleted the accu-chek-error branch November 6, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants