Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CareSens N and True Metrix Pro (UPLOAD-1109, UPLOAD-1120, UPLOAD-1126) #1579

Merged
merged 11 commits into from
Sep 11, 2023

Conversation

gniezen
Copy link
Member

@gniezen gniezen commented Aug 23, 2023

Addresses:

Based against add-bayer-cable-driver branch for UPLOAD-1114, as I've added the Guide Link USB driver in there.

@gniezen gniezen requested a review from krystophv August 23, 2023 08:49
krystophv
krystophv previously approved these changes Aug 23, 2023
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Base automatically changed from add-bayer-cable-driver to master August 29, 2023 09:22
@gniezen gniezen dismissed krystophv’s stale review August 29, 2023 09:22

The base branch was changed.

@gniezen gniezen changed the title Add support for Accu-chek Guide Link, CareSens N and True Metrix Pro (UPLOAD-1109, UPLOAD-1120, UPLOAD-1126) Add support for CareSens N and True Metrix Pro (UPLOAD-1109, UPLOAD-1120, UPLOAD-1126) Aug 29, 2023
@gniezen
Copy link
Member Author

gniezen commented Aug 29, 2023

@krystophv Maybe another review is necessary here since I removed the Accu-chek Guide Link (as the USB is disabled on this meter)

@gniezen gniezen requested a review from krystophv August 29, 2023 10:22
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM 🚀

@gniezen gniezen merged commit aca772c into master Sep 11, 2023
@gniezen gniezen deleted the add-new-meters branch September 11, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants