Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPLOAD-1123] prevent hashchange events when authenticated #1574

Merged
merged 4 commits into from
Aug 14, 2023
Merged

[UPLOAD-1123] prevent hashchange events when authenticated #1574

merged 4 commits into from
Aug 14, 2023

Conversation

krystophv
Copy link
Member

@krystophv krystophv commented Aug 11, 2023 •
edited
Loading

For UPLOAD-1123

  • checks for the latest keycloak event to be more judicious with error state logging
  • only process hashchange events when not authenticated to prevent trying to re-process hashes that come in from repeat clicking the Launch Uploader button in Web
  • clear the refreshTimeout if it exists on component unmount

@krystophv krystophv changed the title [UPLOAD-1123] prevent duplicate hashchange events [UPLOAD-1123] prevent hashchange events when authenticated Aug 11, 2023
clintonium-119
clintonium-119 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@clintonium-119 clintonium-119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 💯

@krystophv krystophv merged commit bf5bb36 into master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintonium-119 clintonium-119 clintonium-119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystophv @clintonium-119