[BACK-3269] basic settings for oauth #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinkrauss
reviewed
Dec 2, 2024
There was a problem hiding this comment.
A couple of questions, but it looks fine pending one question in Slack: https://tidepoolteam.slack.com/archives/C07F46SL6QZ/p1733180554738719
Once that question is answered, I'll approve.
darinkrauss
requested changes
Dec 4, 2024
darinkrauss
requested changes
Dec 7, 2024
jh-bate
force-pushed
the
provider_params
branch
from
2b8442a to
45ae644
Compare
darinkrauss
approved these changes
Dec 10, 2024
| configmap: | ||
| # -- whether to generate a configmap | ||
| enabled: true | ||
| redirectURL: "" |
There was a problem hiding this comment.
Do we want to add defaults for tokenURL and authorizeURL here, too, per our discussion yesterday? Perhaps alphabetically ordered?
| | Key | Type | Default | Description | | ||
| |-----|------|---------|-------------| | ||
| | configmap.enabled | bool | `true` | whether to generate a configmap | | ||
| | configmap.redirectURL | string | `""` | | |
There was a problem hiding this comment.
Perhaps add the other configmap fields here, too?
darinkrauss
requested changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.