-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS support #7
TLS support #7
Conversation
var err error | ||
tlsConfig, err = loadTLSConfig(config[domain].TLSCACert, config[domain].TLSCert, config[domain].TLSKey, config[domain].TLSVerify) | ||
if err != nil { | ||
log.Fatalf("Unable to load tls config for %s: %s", domain, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this to match the prose style of the other Fatalf
calls here? ie, error: unable to load tls config for %s: %s\n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
A few minor nits, but otherwise looking good! 👍 |
Would you mind also testing this against a TLS-enabled Docker daemon, just to make sure we cover our bases? |
Will do, thanks for the comments! 😄 |
I just tested against a TLS-enabled Docker daemon using the following configuration:
Works fine:
|
Nice, LGTM thanks! 👍 |
Hey @tianon, let me know what you think of this :) Would appreciate your feedback! 🐳