-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump example project to Angular 8 #311
Conversation
Just realized a changelog entry is still missing. Will add it soon! |
|
There are polyfill libraries that are way more lightweight than |
Last Force Push
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Also `core-js` is no longer a peer dependency of `jest-preset-angular`. It instead is now a direct dependency.
Last Force Push:
|
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. The jest config of users will have to be adjusted, see the CHANGELOG.md for migration information.
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. The jest config of users will have to be adjusted, see the CHANGELOG.md for migration information.
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. The jest config of users will have to be adjusted, see the CHANGELOG.md for migration information.
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. The jest config of users will have to be adjusted, see the CHANGELOG.md for migration information.
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. The jest config of users will have to be adjusted, see the CHANGELOG.md for migration information. Closes thymikee#308
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. The jest config of users will have to be adjusted, see the CHANGELOG.md for migration information. Closes thymikee#308
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. The jest config of users will have to be adjusted, see the CHANGELOG.md for migration information. Closes thymikee#308
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. Furthermore `ts-jest` is not a dependency of the preset anymore. The jest config and package.json of users will have to be adjusted, see the CHANGELOG.md for migration information. Closes thymikee#308
BREAKING CHANGE: add an alternative preset for babel and restructures the whole repository to treat babel and ts-jest equally. Furthermore `ts-jest` is not a dependency of the preset anymore. The jest config and package.json of users will have to be adjusted, see the CHANGELOG.md for migration information. Closes thymikee#308
I did most adjustments to be in sync with the default Angular CLI Boilerplate. I know many Angular projects will still differ from this, but I feel like it is the default starting point in the community. Open to discussion regarding this.
Changes in example project:
angular.json
, as it looks quite different in current generated projects, but updating also the e2e folder seemed out of scope.Question: Should we remove the e2e source folder as well? Or keep everything also in
angular.json
in sync to the boilerplate of angular 8?package.json
using~x.x.x
.Question: Should we keep all versions locked in the example project as well?
core-js
from peerDependencies, it is not a dependency of Angular projects anymore, and made it a dependency ofjest-preset-angular
, as we need it for testing. See Angular no longer directly depends on core-js - should not be a peerDependency #266 for further discussion.HttpModule
withHttpClientModule
(HttpModule
was dropped completely)tsconfig.json
baseUrl
is now the root folder, as it is in the Angular CLI boilerplate projecttsconfig.spec.json
needsemitDecoratorMetadata: true
(or access to program/type checker through ts-jest), see After upgrade Angular to v8: Can't resolve all parameters for Component: (?). #288ng build --aot
not fail:[\`styles\`]: ...
had to becomestyles: ...
again and declared all components toapp.module
polyfills.ts
to current oneNote that most tested files and tests remained untouched. Mostly the Angular Project files were changed.
Is this breaking due to moving
core-js
to dependencies?Renaming the example project to e. g.
test-app
would be another task I would like to start with after this PR.I would like to keep #288 open, as the cleaner approach might be a transformer (one day).
Solves #266.