feat: Support tsconfig.spec.json in root dir by default #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular version >= 8 project do locate all of their tsconfig files in the root directory by default. This preset now supports the config files in the root directory by default as well, without any necessity to adjust the jest configuration.
thymikee
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular version >= 8 projects do locate all of their tsconfig files in the root directory by default (after generation with the angular cli). This preset now supports the config files in the root directory by default as well, without any necessity to adjust the jest configuration.
This will enable newcomers to setup jest with angular quicker and easier.
If someone has their config located in a different place, that can still be configured following the documentation in the README.md.
Sidenote: This PR is breaking, solves #286 without workaround.