Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ts-jest, @types/jest #173

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Upgrade ts-jest, @types/jest #173

merged 2 commits into from
Aug 3, 2018

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jul 22, 2018

  • Upgrade ts-jest to 23.0.1
  • Upgrade @types/jest to 23.3.0
  • Upgrade devDependencies for jest

I noticed that relative path resolving for tsconfig seems to be broken by ts-jest. I'm not sure if we should wait for them to fix that issue before we can release 6.0

@thymikee
Copy link
Owner

Maybe they changed something, is this intended or a regression?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Jul 22, 2018

I think it's more about a regression. Here is the reported issue.

I did try jest 23 with our current preset version and it seems to work for my company projects at least. Not sure if other people encounter something differently. From my point of view, we still can wait for ts-jest to fix that issue first.

@thymikee
Copy link
Owner

Cool, let's wait then

@thymikee thymikee mentioned this pull request Aug 3, 2018
@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Aug 3, 2018

@thymikee done upgrading to latest ts-jest major version. I think it's stable now on their side.

@thymikee thymikee merged commit 9781f63 into thymikee:master Aug 3, 2018
@thymikee
Copy link
Owner

thymikee commented Aug 3, 2018

Thank you @ahnpnl, I'll trust you on that :) Releasing v6.0.0 in a minute

@ahnpnl ahnpnl deleted the chore/update-dependencies branch August 3, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants